Skip to content

Add tidb index usage limitation for valid stats #20249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 1 commit into from
May 6, 2025
Merged

Add tidb index usage limitation for valid stats #20249

ti-chi-bot merged 1 commit into from
May 6, 2025

Conversation

@YangKeao
Copy link
Member

@YangKeao YangKeao commented Apr 22, 2025 •
edited by qiancai
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a limitation to the tidb usage limitation. The description is aligned with the "index-advisor.md":

The data in INFORMATION_SCHEMA.CLUSTER_TIDB_INDEX_USAGE might be delayed by up to five minutes, and the usage data is reset whenever a TiDB node restarts. Additionally, index usage is only recorded if the table has valid statistics.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2025
@YangKeao YangKeao changed the title add tidb usage limitation with stats Add tidb index usage limitation for valid stats Apr 22, 2025
@YangKeao YangKeao mentioned this pull request Apr 22, 2025
Merged
16 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 22, 2025

@lcwangchao: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qiancai
qiancai approved these changes Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

information-schema/information-schema-tidb-index-usage.md Outdated

- `TIDB_INDEX_USAGE` 表中的数据可能存在最多 5 分钟的延迟。
- 在 TiDB 重启后，`TIDB_INDEX_USAGE` 表中的数据会被清空。
- 只有在表具有有效统计信息时，才会记录该表的索引使用情况。
Copy link
Collaborator

@qiancai qiancai Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 只有在表具有有效统计信息时，才会记录该表的索引使用情况。
- 只有在表具有有效统计信息时，TiDB 才会记录该表的索引使用情况。

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 23, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-23 10:02:25.953354058 +0000 UTC m=+436289.765144431: ☑️ agreed by qiancai.

@qiancai qiancai self-assigned this Apr 23, 2025
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Apr 23, 2025
@YangKeao YangKeao force-pushed the add-tidb-usage-limitation branch from 6008113 to 8f6e28a Compare April 24, 2025 07:10
@qiancai
Copy link
Collaborator

qiancai commented May 6, 2025

/approve

@qiancai qiancai added the lgtm label May 6, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 6, 2025
@ti-chi-bot ti-chi-bot bot merged commit 2f43c3a into pingcap:master May 6, 2025
7 checks passed
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 6, 2025

In response to a cherrypick label: new pull request created to branch release-8.1: #20315.

@ti-chi-bot ti-chi-bot mentioned this pull request May 6, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 6, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #20316.

This was referenced May 6, 2025
Merged
Merged
@ti-chi-bot ti-chi-bot mentioned this pull request May 6, 2025
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this pull request May 10, 2025
@ti-chi-bot
Add tidb index usage limitation for valid stats (#20249) (#20316)
a6657db
ti-chi-bot bot pushed a commit that referenced this pull request May 10, 2025
@ti-chi-bot
Add tidb index usage limitation for valid stats (#20249) (#20315)
69f8f0f
JaySon-Huang pushed a commit to JaySon-Huang/docs-cn that referenced this pull request Jun 13, 2025
@YangKeao @JaySon-Huang
Add tidb index usage limitation for valid stats (pingcap#20249)
c4b4bf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@qiancai qiancai

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YangKeao @qiancai @ti-chi-bot @lcwangchao